Discussion:
hexdump(1) - unneeded headers
Michal Mazurek
2016-02-08 13:13:40 UTC
Permalink
These headers appear to be unneeded:

Index: conv.c
===================================================================
RCS file: /cvs/src/usr.bin/hexdump/conv.c,v
retrieving revision 1.10
diff -u -p -r1.10 conv.c
--- conv.c 19 Apr 2014 09:28:20 -0000 1.10
+++ conv.c 8 Feb 2016 12:59:43 -0000
@@ -30,10 +30,8 @@
* SUCH DAMAGE.
*/

-#include <sys/types.h>
-
-#include <stdio.h>
#include <ctype.h>
+#include <stdio.h>

#include "hexdump.h"

Index: display.c
===================================================================
RCS file: /cvs/src/usr.bin/hexdump/display.c,v
retrieving revision 1.21
diff -u -p -r1.21 display.c
--- display.c 16 Jan 2015 06:40:08 -0000 1.21
+++ display.c 8 Feb 2016 12:59:43 -0000
@@ -34,11 +34,9 @@

#include <ctype.h>
#include <err.h>
-#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <unistd.h>

#include "hexdump.h"

Index: hexdump.c
===================================================================
RCS file: /cvs/src/usr.bin/hexdump/hexdump.c,v
retrieving revision 1.19
diff -u -p -r1.19 hexdump.c
--- hexdump.c 9 Oct 2015 01:37:07 -0000 1.19
+++ hexdump.c 8 Feb 2016 12:59:43 -0000
@@ -31,10 +31,10 @@
*/

#include <err.h>
-#include <stdio.h>
#include <stdlib.h>
-#include <unistd.h>
#include <string.h>
+#include <unistd.h>
+
#include "hexdump.h"

#define MINIMUM(a, b) (((a) < (b)) ? (a) : (b))
Index: hexsyntax.c
===================================================================
RCS file: /cvs/src/usr.bin/hexdump/hexsyntax.c,v
retrieving revision 1.12
diff -u -p -r1.12 hexsyntax.c
--- hexsyntax.c 6 May 2011 15:46:29 -0000 1.12
+++ hexsyntax.c 8 Feb 2016 12:59:43 -0000
@@ -30,13 +30,10 @@
* SUCH DAMAGE.
*/

-#include <sys/types.h>
-
#include <err.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
-#include <string.h>
#include <unistd.h>

#include "hexdump.h"
Index: odsyntax.c
===================================================================
RCS file: /cvs/src/usr.bin/hexdump/odsyntax.c,v
retrieving revision 1.26
diff -u -p -r1.26 odsyntax.c
--- odsyntax.c 16 Sep 2015 08:47:26 -0000 1.26
+++ odsyntax.c 8 Feb 2016 12:59:43 -0000
@@ -30,8 +30,6 @@
* SUCH DAMAGE.
*/

-#include <sys/types.h>
-
#include <ctype.h>
#include <err.h>
#include <stdio.h>
Index: parse.c
===================================================================
RCS file: /cvs/src/usr.bin/hexdump/parse.c,v
retrieving revision 1.17
diff -u -p -r1.17 parse.c
--- parse.c 27 Oct 2009 23:59:39 -0000 1.17
+++ parse.c 8 Feb 2016 12:59:43 -0000
@@ -30,13 +30,8 @@
* SUCH DAMAGE.
*/

-#include <sys/types.h>
-#include <sys/file.h>
-
#include <ctype.h>
#include <err.h>
-#include <errno.h>
-#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
--
Michal Mazurek
Loading...