Discussion:
less.h small cleanup
Michael Reed
2016-01-26 19:02:11 UTC
Permalink
- sorts includes + remove unneeded comment
- less.h 1.24[1] removes the only use of CHAR_BIT, so remove it
- remove SHELL_META_QUEST, doesn't seem to be used either

[1]: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/less/less.h.diff?r1=1.23&r2=1.24&sortby=date&f=h

Index: less.h
===================================================================
RCS file: /cvs/src/usr.bin/less/less.h,v
retrieving revision 1.24
diff -u -p -r1.24 less.h
--- less.h 26 Jan 2016 01:51:06 -0000 1.24
+++ less.h 26 Jan 2016 18:58:20 -0000
@@ -15,19 +15,18 @@

#include "defines.h"

-/* Library function declarations */
-
#include <sys/types.h>
-#include <stdio.h>
-#include <fcntl.h>
-#include <unistd.h>
+
#include <ctype.h>
-#include <wctype.h>
+#include <fcntl.h>
+#include <libgen.h>
#include <limits.h>
+#include <signal.h>
+#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <libgen.h>
-#include <signal.h>
+#include <unistd.h>
+#include <wctype.h>

/*
* Simple lowercase test which can be used during option processing
@@ -53,18 +52,12 @@
#define OPT_ON 1
#define OPT_ONPLUS 2

-#ifndef CHAR_BIT
-#define CHAR_BIT 8
-#endif
-
/*
* Special types and constants.
*/
typedef unsigned long LWCHAR;
#define MIN_LINENUM_WIDTH 7 /* Min printing width of a line number */
#define MAX_UTF_CHAR_LEN 6 /* Max bytes in one UTF-8 char */
-
-#define SHELL_META_QUEST 1

/*
* An IFILE represents an input file.
Michael McConville
2016-01-29 16:14:29 UTC
Permalink
Post by Michael Reed
- sorts includes + remove unneeded comment
- less.h 1.24[1] removes the only use of CHAR_BIT, so remove it
Committed. Thanks!
Post by Michael Reed
- remove SHELL_META_QUEST, doesn't seem to be used either
I'm going to leave this for now because I don't know what it is/was.
Loading...